Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build path base on BFS through adjancency list (#1669) #5002

Merged
merged 5 commits into from
Dec 14, 2022
Merged

build path base on BFS through adjancency list (#1669) #5002

merged 5 commits into from
Dec 14, 2022
+430 −375

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Dec 6, 2022 •
edited
Loading

  • build path base on BFS through adjancency list

  • fix error

  • add multi-thread

  • fix error

  • change filter path

  • fix ci test error

  • address comment

Co-authored-by: Yee 2520865+yixinglu@users.noreply.github.com

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels Dec 6, 2022
@yixinglu
Copy link
Contributor

yixinglu commented Dec 8, 2022

@nevermore3 plz fix the tck tests

nevermore3 and others added 2 commits December 9, 2022 14:40
@nevermore3 @yixinglu
build path base on BFS through adjancency list (vesoft-inc#1669)
3f2c635 
* build path base on BFS through adjancency list

* fix error

* add multi-thread

* fix error

* change filter path

* fix ci test error

* address comment

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
@nevermore3
fix test error
b695c28
@nevermore3
Copy link
Contributor Author

@nevermore3 plz fix the tck tests

done

@codecov-commenter
Copy link

Codecov Report

Base: 77.22% // Head: 77.28% // Increases project coverage by +0.06% 🎉

Coverage data is based on head (f6b2597) compared to base (cc0ce34).
Patch coverage: 83.03% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5002      +/-   ##
==========================================
+ Coverage   77.22%   77.28%   +0.06%     
==========================================
  Files        1105     1105              
  Lines       82059    82104      +45     
==========================================
+ Hits        63366    63458      +92     
+ Misses      18693    18646      -47
Impacted Files Coverage Δ
src/graph/executor/query/ProjectExecutor.cpp 61.11% <ø> (-2.78%) ⬇️
src/graph/executor/query/TraverseExecutor.cpp 84.90% <82.06%> (+17.19%) ⬆️
src/graph/executor/query/TraverseExecutor.h 96.42% <95.23%> (-3.58%) ⬇️
src/meta/processors/parts/GetSpaceProcessor.cpp 61.29% <0.00%> (-19.36%) ⬇️
src/kvstore/raftex/Host.cpp 71.70% <0.00%> (-2.58%) ⬇️
src/meta/processors/parts/ListHostsProcessor.cpp 69.52% <0.00%> (-2.15%) ⬇️
src/storage/mutate/AddVerticesProcessor.cpp 86.07% <0.00%> (-2.11%) ⬇️
src/kvstore/raftex/RaftPart.cpp 69.54% <0.00%> (-2.07%) ⬇️
src/parser/GraphScanner.h 92.63% <0.00%> (-2.00%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Aiee
Aiee reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider use robin_hood::unordered_flat_ to replace std::set and std::map

src/graph/executor/query/TraverseExecutor.cpp Show resolved Hide resolved
Aiee
Aiee reviewed Dec 13, 2022
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider use robin_hood::unordered_flat_ to replace std::set and std::map

@nevermore3
Copy link
Contributor Author

Consider use robin_hood::unordered_flat_ to replace std::set and std::map

will be considered if there is a significant improvement in performance

Aiee
Aiee approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider use robin_hood::unordered_flat_ to replace std::set and std::map

@yixinglu yixinglu merged commit 4c6b05b into vesoft-inc:master Dec 14, 2022
@wey-gu wey-gu mentioned this pull request Dec 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jievince jievince jievince approved these changes

@Aiee Aiee Aiee approved these changes

@yixinglu yixinglu yixinglu approved these changes

@xtcyclist xtcyclist Awaiting requested review from xtcyclist

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

@codesigner codesigner Awaiting requested review from codesigner

@czpmango czpmango Awaiting requested review from czpmango

@dutor dutor Awaiting requested review from dutor

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nevermore3 @yixinglu @codecov-commenter @Aiee @jievince